Skip to content

feat: add lapack/base/dsptrf#13288

Open
iampratik13 wants to merge 1 commit into
stdlib-js:developfrom
iampratik13:lapack/dsptrf
Open

feat: add lapack/base/dsptrf#13288
iampratik13 wants to merge 1 commit into
stdlib-js:developfrom
iampratik13:lapack/dsptrf

Conversation

@iampratik13

@iampratik13 iampratik13 commented Jul 5, 2026

Copy link
Copy Markdown
Member

type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes. report:

  • task: lint_filenames status: passed
  • task: lint_editorconfig status: passed
  • task: lint_markdown_pkg_readmes status: passed
  • task: lint_markdown_docs status: na
  • task: lint_markdown status: na
  • task: lint_package_json status: passed
  • task: lint_repl_help status: passed
  • task: lint_javascript_src status: passed
  • task: lint_javascript_cli status: na
  • task: lint_javascript_examples status: passed
  • task: lint_javascript_tests status: passed
  • task: lint_javascript_benchmarks status: passed
  • task: lint_python status: na
  • task: lint_r status: na
  • task: lint_c_src status: na
  • task: lint_c_examples status: na
  • task: lint_c_benchmarks status: na
  • task: lint_c_tests_fixtures status: na
  • task: lint_shell status: na
  • task: lint_typescript_declarations status: passed
  • task: lint_typescript_tests status: passed
  • task: lint_license_headers status: passed ---

Resolves none.

Description

What is the purpose of this pull request?

This pull request:

  • feat: add lapack/base/dsptrf

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

  • none.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

{{TODO: add disclosure if applicable}}

@stdlib-js/reviewers

@iampratik13
feat: add lapack/base/dsptrf
dbdb8a1 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown_pkg_readmes
    status: passed
  - task: lint_markdown_docs
    status: na
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: passed
  - task: lint_repl_help
    status: passed
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: passed
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: passed
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: passed
  - task: lint_license_headers
    status: passed
---
@iampratik13 iampratik13 requested a review from a team July 5, 2026 14:40
@stdlib-bot stdlib-bot added LAPACK Issue or pull request related to the Linear Algebra Package (LAPACK). Needs Review A pull request which needs code review. labels Jul 5, 2026
@stdlib-bot

stdlib-bot commented Jul 5, 2026

Copy link
Copy Markdown
Contributor

Coverage Report

Package Statements Branches Functions Lines
lapack/base/dsptrf $\\color{green}688/688$
$\\color{green}+100.00\\%$ 		$\\color{green}88/88$
$\\color{green}+100.00\\%$ 		$\\color{green}7/7$
$\\color{green}+100.00\\%$ 		$\\color{green}688/688$
$\\color{green}+100.00\\%$

The above coverage report was generated for the changes in this PR.

@iampratik13 iampratik13 added Feature Issue or pull request for adding a new feature. GSoC Google Summer of Code. gsoc: 2026 Google Summer of Code (2026). labels Jul 5, 2026
@iampratik13 iampratik13 mentioned this pull request Jul 6, 2026
Open
kgryte
kgryte reviewed Jul 10, 2026
View reviewed changes
Comment thread lib/node_modules/@stdlib/lapack/base/dsptrf/test/fixtures/column_major_lower.json

@kgryte kgryte Jul 10, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sort of formatting is not particularly helpful. The purpose of A is to provide an easy visual representation of the matrix. This sort of layout puts the onus of visual reconstruction on the reader.

kgryte
kgryte reviewed Jul 10, 2026
View reviewed changes
Comment thread lib/node_modules/@stdlib/lapack/base/dsptrf/lib/base.js

@kgryte kgryte Jul 10, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can avoid needing to create a closure by simply making pos( oa, sa, idx ) and passing in oa and sa explicitly at the call sites below. That is preferable due to how optimizing compilers work.

kgryte
kgryte reviewed Jul 10, 2026
View reviewed changes
Comment thread lib/node_modules/@stdlib/lapack/base/dsptrf/lib/base.js

@kgryte kgryte Jul 10, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// Interchange rows and columns `kk` and `kp` in the leading submatrix `A(0:k-1,0:k-1)`...

Is it actually 1:k or is that one-based indexing? If the latter, make sure docs reflect zero-based indexing; otherwise, that is going to be misleading for people reading the code.

kgryte
kgryte reviewed Jul 10, 2026
View reviewed changes
Comment thread lib/node_modules/@stdlib/lapack/base/dsptrf/lib/base.js

@kgryte kgryte Jul 10, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comments. Are the indices in these comments all using one-based indexing? It is not clear.

kgryte
kgryte reviewed Jul 10, 2026
View reviewed changes
Comment thread lib/node_modules/@stdlib/lapack/base/dsptrf/lib/base.js
Comment on lines 187 to 188

@kgryte kgryte Jul 10, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use temporary variables here and below. These indexing expressions are repetitive and make the expressions hard to read.

kgryte
kgryte reviewed Jul 10, 2026
View reviewed changes
Comment thread lib/node_modules/@stdlib/lapack/base/dsptrf/lib/base.js
kgryte
kgryte reviewed Jul 10, 2026
View reviewed changes
Comment thread lib/node_modules/@stdlib/lapack/base/dsptrf/lib/base.js
Comment on lines 354 to 366

@kgryte kgryte Jul 10, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have a lot of repeated calculations here. Figure out a way to simplify and clean-up.

kgryte
kgryte requested changes Jul 10, 2026
View reviewed changes

@kgryte kgryte left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left initial comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kgryte kgryte kgryte requested changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

Feature Issue or pull request for adding a new feature. GSoC Google Summer of Code. gsoc: 2026 Google Summer of Code (2026). LAPACK Issue or pull request related to the Linear Algebra Package (LAPACK). Needs Review A pull request which needs code review.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@iampratik13 @stdlib-bot @kgryte